Repository navigation
Conversation
…bers with the right function
jgohel9902
left a comment
There was a problem hiding this comment.
Thanks for the update. I checked the new version against len(str(abs(n))) up to 599 digits and 200,000 random values with no mismatches, so the correction is solid. A few small suggestions: add a 10**15 - 1 doctest, and add a comment explaining why the exact check is needed.
| 4 | ||
| >>> num_digits_fast(10**15) | ||
| 16 | ||
| >>> num_digits_fast(10**16 - 1) |
There was a problem hiding this comment.
The new doctests look good, including 1050 - 1 and the negative case. One more worth adding is 1015 - 1 (expected 15): in my check the plain floor(log10(n) + 1) formula is already wrong from that value onward, so it is the first value the correction step actually has to fix. Also 10**15 itself is covered by the existing doctest, which is a good neighbour for it.
| return 1 | ||
|
|
||
| abs_n = abs(n) | ||
| digits = math.floor(math.log10(abs_n) + 1) |
There was a problem hiding this comment.
The correction below makes this safe: I compared the function with len(str(abs(n))) for 10k - 1, 10k and 10**k + 1 for every k up to 599, and for 200,000 random values with up to 300 digits, with no mismatches. One small thought: floor(log10(abs_n)) + 1 and floor(log10(abs_n) + 1) can differ by float rounding right before a power of ten, so the code relies entirely on the correction. A one-line comment saying so would help readers.
|
|
||
| abs_n = abs(n) | ||
| digits = math.floor(math.log10(abs_n) + 1) | ||
| if abs_n < 10 ** (digits - 1): |
There was a problem hiding this comment.
Could you add a short comment above the correction explaining why it exists? For example: "log10 on a float can be off by one near powers of ten, since ints above 2**53 lose precision when converted to float; correct it exactly with integer comparisons." The explanation is easy to lose later, and without it the next reader may remove the check as redundant.
| 1 | ||
| >>> num_digits_faster(-123456) | ||
| 6 | ||
| >>> num_digits_faster('123') # Raises a TypeError for non-integer input |
There was a problem hiding this comment.
Out of scope for this PR, but worth a follow-up: after this change num_digits_fast is no longer faster than len(str(abs(n))) in a quick timing (about 3.5x slower on 2**100). Could you paste benchmark() output before and after in the description, so the name still matches the numbers?
Describe your change
Fixes #15753
num_digits_fast()inmaths/number_of_digits.pypreviously evaluatedmath.floor(math.log10(abs(n)) + 1). For integers whereabs(n) >= 10**16 - 1(exceeding IEEE 754 53-bit float mantissa precision), floating-point rounding near powers of ten caused an off-by-one error (e.g.num_digits_fast(10**16 - 1)evaluated to 17 instead of 16).This fix verifies the logarithmic estimate against integer powers of ten ($O(1)$ fast calculation speed. Added regression doctests covering boundary values ($10^{16}-1$ , $10^{16}$ , $10^{50}-1$ , and negative integers).
10 ** (digits - 1)and10 ** digits), correcting any floating-point rounding discrepancies while maintainingChecklist